feiniaofeiafei opened a new pull request, #64084:
URL: https://github.com/apache/doris/pull/64084
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: FE constant folding for DATEDIFF used Java proleptic date
arithmetic, while BE runtime evaluates DATEDIFF by subtracting Doris day
numbers. For zero-date inputs such as 0000-01-01, Java date arithmetic
disagrees with Doris day-number semantics, so folded DATEDIFF could return a
different result from runtime execution and from TO_DAYS(a) - TO_DAYS(b). This
change reuses the FE day-number calculation used by TO_DAYS for DATEDIFF
folding, keeping folded and runtime semantics consistent for zero-date boundary
cases.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- Attempted: ./run-fe-ut.sh --run
org.apache.doris.nereids.rules.expression.FoldConstantTest
- Result: failed before running tests because current FE compile fails
in LogicalPlanBuilder.java with missing ctx.HOT(); the DATEDIFF-specific
compile errors found in the first run were fixed and did not recur.
- Behavior changed: No
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
