freemandealer commented on code in PR #62384:
URL: https://github.com/apache/doris/pull/62384#discussion_r3341266911
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/CacheHotspotManager.java:
##########
@@ -781,6 +962,31 @@ public Map<Long, List<Tablet>>
warmUpNewClusterByTable(long jobId, String dstClu
}
public long createJob(WarmUpClusterCommand stmt) throws AnalysisException {
+ OncePendingJobKey oncePendingJobKey = buildOncePendingJobKey(stmt);
+ if (oncePendingJobKey != null) {
+ RefCountedPendingCreateLock createLock =
retainOncePendingCreateLock(oncePendingJobKey);
+ createLock.lock();
+ try {
+ CloudWarmUpJob existingPendingJob =
findExistingPendingOnceJob(oncePendingJobKey);
+ if (existingPendingJob != null) {
Review Comment:
not ganna happen this way because we have used locks to protect it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
