This is an automated email from the ASF dual-hosted git repository.
HappenLee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 4901da10194 [Chore] correct null check in
`DictionaryManager.dropTableDictionaries()` (#63630)
4901da10194 is described below
commit 4901da10194516e5c7875f45034bf8b2cd08898c
Author: Yongtao Huang <[email protected]>
AuthorDate: Mon Jun 1 19:57:46 2026 +0800
[Chore] correct null check in `DictionaryManager.dropTableDictionaries()`
(#63630)
Long log:
The null check was mistakenly performed on the `id` parameter instead of
the `dict` returned from `idToDictionary.remove(id)`.
Signed-off-by: Yongtao Huang <[email protected]>
---
.../src/main/java/org/apache/doris/dictionary/DictionaryManager.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/dictionary/DictionaryManager.java
b/fe/fe-core/src/main/java/org/apache/doris/dictionary/DictionaryManager.java
index e503f4045ee..7ebc701c32a 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/dictionary/DictionaryManager.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/dictionary/DictionaryManager.java
@@ -243,7 +243,7 @@ public class DictionaryManager extends MasterDaemon
implements Writable {
Map<String, Long> nameToIds = dictionaryIds.get(dbName);
for (Long id : dictIds) {
Dictionary dict = idToDictionary.remove(id);
- if (id == null) {
+ if (dict == null) {
LOG.warn("Dictionary {} does not exist in dictionaryIds",
id);
continue;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
