heguanhui opened a new pull request, #63860:
URL: https://github.com/apache/doris/pull/63860
### What problem does this PR solve?
Issue Number: close #xxx
Problem Summary: SHOW TRASH ON clause has two bugs:
1. The ON clause is silently ignored due to a missing return statement in
`LogicalPlanBuilder.visitShowTrash()`, causing `SHOW TRASH ON "be:9050"` to
always return trash info for all backends instead of the specified one.
2. `SHOW TRASH ON` only supports a single backend string literal, while
`ADMIN CLEAN TRASH ON` supports multiple backends with parenthesized
comma-separated list. The syntax is inconsistent between the two related
statements.
### Release note
Fix SHOW TRASH ON clause to support multiple backends with the same syntax
as ADMIN CLEAN TRASH ON, e.g. `SHOW TRASH ON ("be1:9050", "be2:9050")`.
Previously the ON clause was silently ignored due to a missing return.
### Check List (For Author)
- Test
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test
- [ ] No need to test
- Behavior changed:
- [ ] No.
- [x] Yes. SHOW TRASH ON now requires parenthesized list syntax
consistent with ADMIN CLEAN TRASH ON.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
