eldenmoon opened a new pull request, #63842:
URL: https://github.com/apache/doris/pull/63842

   ## Proposed changes
   
   - Guard `CachedRemoteFileReader::read_at_impl` against nullable `IOContext`.
   - Pass `NativeReader` `_io_ctx` through header and block reads.
   - Add BE unit coverage for reading through `CachedRemoteFileReader` without 
an explicit `IOContext`.
   
   ## Root cause
   
   `FileReader::read_at` allows callers to omit `IOContext`, but 
`CachedRemoteFileReader::read_at_impl` dereferenced it before checking. 
`NativeReader` also issued header and block reads without forwarding its 
`_io_ctx`, which exposed the cached remote reader to a null context.
   
   ## Test
   
   - `git diff --check`
   - `DORIS_CLANG_HOME=/mnt/disk6/common/ldb_toolchain_026 
DORIS_THIRDPARTY=/mnt/disk6/common/doris-thirdparties/doris-thirdparty-master 
./run-be-ut.sh --run 
--filter='BlockFileCacheTest.cached_remote_file_reader_accepts_null_io_context'`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to