HappenLee commented on code in PR #59263:
URL: https://github.com/apache/doris/pull/59263#discussion_r3316866528
##########
be/src/storage/segment/column_reader.cpp:
##########
@@ -855,14 +855,34 @@ Status
ColumnReader::new_struct_iterator(ColumnIteratorUPtr* iterator,
return Status::OK();
}
+void ColumnIterator::_convert_to_place_holder_column(MutableColumnPtr& dst,
size_t count) {
+ if (_reading_mode == ReadingMode::LAZY) {
+ return;
+ } else if (_reading_flag != ReadingFlag::SKIP_READING &&
Review Comment:
现在代码里面大量用了，这个不等于，但其实这个场景我的理解是只会等于Need_to_read。搞的现在的代码非常乱，我感觉得统一整理一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
