github-actions[bot] commented on code in PR #63822:
URL: https://github.com/apache/doris/pull/63822#discussion_r3316540725
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -97,6 +97,15 @@ void sleep_for_packed_file_retry() {
std::this_thread::sleep_for(std::chrono::milliseconds(packed_file_retry_sleep_ms()));
}
+bool filter_out_instance(const std::string& instance_id) {
Review Comment:
This direct read does not make the filter dynamically configurable in
production. `recycle_whitelist` and `recycle_blacklist` are still declared as
`CONF_Strings` in `cloud/src/common/config.h`, so `config::set_config` rejects
them as immutable, and `do_set_config` only handles scalar types plus
`std::string`, not `std::vector<std::string>`. The new test mutates the globals
directly, but the supported runtime update path cannot do that, so recycler
filtering still cannot be changed without restart. Please make these configs
genuinely mutable through the config API (with a safe read/update mechanism for
the vectors) and test that path rather than direct assignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
