github-actions[bot] commented on code in PR #61516:
URL: https://github.com/apache/doris/pull/61516#discussion_r3315251224
##########
cloud/src/common/metric.cpp:
##########
@@ -195,6 +205,12 @@ static void export_fdb_status_details(const std::string&
status_str) {
// Backup and DR
+ // Performance Limited By
+ // invalid or not-workload, the final value is -1
+ int64_t performance_val =
Review Comment:
This maps any missing or malformed `qos.performance_limited_by.name` to
`-1`, which is also the value later interpreted as a real non-workload FDB
pressure reason. For example, if the FDB status JSON is from a version that
does not contain `qos.performance_limited_by.name`, `get_string_value(...)`
returns `"invalid"`, `g_bvar_fdb_performance_limited_by_name` becomes `-1`, and
`MsStressDetector::update()` will set `fdb_cluster_under_pressure` whenever
commit/read latency is high because the value is neither
`BVAR_FDB_INVALID_VALUE` nor `0`. That can reject rowset/delete-bitmap RPCs
even though we did not actually observe a non-workload FDB bottleneck. Please
keep parse failures/missing fields as `BVAR_FDB_INVALID_VALUE` and only use the
non-workload value when the field is present and explicitly not `workload`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
