mrhhsg commented on PR #63767: URL: https://github.com/apache/doris/pull/63767#issuecomment-4559301461
Addressed the request-change feedback in `81394a28673`. Changes: - When `find_null_aware_with_other_conjuncts` stops on a NULL probe row, it now clears `build_idx` and `picking_null_keys` before returning. This keeps the downstream invariant that `probe_idx` still points to the NULL row and prevents the continuation rewind path from being triggered by a build-side NULL-key bucket. - Added a regression case where the build side contains a NULL key for the correlated `NOT IN` + disjunction mark join path. Validated: - `build-support/clang-format.sh be/src/exec/common/hash_table/join_hash_table.h && git diff --check` - `./build.sh --be` - `doris-local-regression.sh --network 10.26.20.3/24 run -d correctness -s test_subquery_in_disjunction -forceGenOut` - `doris-local-regression.sh --network 10.26.20.3/24 run -d correctness -s test_subquery_in_disjunction` /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
