hello-stephen opened a new pull request, #63762:
URL: https://github.com/apache/doris/pull/63762

   ## Problem
   
   PR #63597 cherry-picked the code change from master (via #61832) that 
switches `enable_deprecated_int96_timestamps()` to 
`enable_force_write_int96_timestamps()` in `vparquet_transformer.cpp`, but did 
**not** carry over the two Arrow 17.0.0 patches that introduce this new method 
into the thirdparty library.
   
   Without the patches, Arrow 17.0.0 only exposes 
`enable_deprecated_int96_timestamps()`, causing a compile error:
   
   ```
   error: no member named 'enable_force_write_int96_timestamps' in 
'parquet::ArrowWriterProperties::Builder';
          did you mean 'enable_deprecated_int96_timestamps'?
   ```
   
   ## Root Cause
   
   master has two Arrow patches that branch-4.0 was missing:
   - `apache-arrow-17.0.0-paimon.patch` — prerequisite; adds the NANO unit 
guard in `schema.cc` that the next patch's context depends on
   - `apache-arrow-17.0.0-force-write-int96-timestamps.patch` — adds the 
`enable_force_write_int96_timestamps()` API to `properties.h` and the 
corresponding logic to `schema.cc`
   
   ## Fix
   
   Add both patch files and register them in `download-thirdparty.sh` in the 
same order as master:
   1. `apache-arrow-17.0.0-paimon.patch`
   2. `apache-arrow-17.0.0-force-write-int96-timestamps.patch`
   3. `apache-arrow-17.0.0-status-inline-static-fix.patch` (already present)
   
   ## Related
   
   - #61832 (master, original fix)
   - #63597 (branch-4.0 cherry-pick, incomplete)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to