github-actions[bot] commented on code in PR #63653: URL: https://github.com/apache/doris/pull/63653#discussion_r3308105254
########## regression-test/suites/variant_p0/nested.groovy: ########## @@ -1,188 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. - -suite("regression_test_variant_nested", "p0"){ Review Comment: This active p0 suite is being deleted rather than moved or retagged, which removes substantial coverage for flattened nested variant behavior: schema description, compaction after nested-path expansion, nested-path predicates, insert-into-select, `array_contains`, and `explode_variant_array` error handling. If the goal is to avoid unstable p0 execution, please move/retag the suite (or isolate the flaky portions) instead of dropping the coverage entirely. ########## regression-test/suites/variant_p0/nested/nested_in_top_array.groovy: ########## @@ -1,135 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. - -// this test is used to test the nested in top array Review Comment: This is also an active p0 suite and it is not covered by the remaining variant tests I found. Deleting it removes coverage for top-level variant arrays, type/structure conflicts, array/scalar casts, the expected ambiguous-structure exception, and post-compaction reads. Please quarantine or retag it if it is unstable rather than removing the test coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
