yujun777 commented on code in PR #63625:
URL: https://github.com/apache/doris/pull/63625#discussion_r3303315021
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisManager.java:
##########
@@ -381,6 +381,9 @@ public AnalysisInfo
buildAnalysisJobInfo(AnalyzeTableCommand command) {
infoBuilder.setCronExpression(cronExpression);
infoBuilder.setForceFull(command.forceFull());
infoBuilder.setUsingSqlForExternalTable(command.usingSqlForExternalTable());
+ AnalyzeProperties analyzeProperties = command.getAnalyzeProperties();
+ infoBuilder.setCollectHotValue((analyzeProperties.hasCollectHotValue()
Review Comment:
Fixed in the latest commit. `ExternalAnalysisTask.doFull()` now uses
`FULL_ANALYZE_WITHOUT_HOT_VALUE_TEMPLATE` by default and only switches to
`FULL_ANALYZE_TEMPLATE` when `collectHotValue` is true. I also added HMS
coverage for both default full analyze and explicit hot-value collection, and
verified `external_table_p0/hive/test_hive_statistics_p0`.
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/OlapAnalysisTask.java:
##########
@@ -330,14 +330,22 @@ protected void doFull() throws Exception {
doPartitionTable();
Review Comment:
This is an existing limitation of the partition statistics path. Partitioned
OLAP full analyze still goes through `doPartitionTable()` and does not collect
hot values in this PR; this change intentionally keeps that behavior unchanged
and only fixes the default hot-value behavior plus the external-table path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
