gavinchou commented on code in PR #63504:
URL: https://github.com/apache/doris/pull/63504#discussion_r3301934479
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -2090,35 +2191,46 @@ void BlockFileCache::run_background_block_lru_update() {
Thread::set_self_name("run_background_block_lru_update");
std::vector<FileBlockSPtr> batch;
while (!_close) {
- int64_t interval_ms =
config::file_cache_background_block_lru_update_interval_ms;
- size_t batch_limit =
- config::file_cache_background_block_lru_update_qps_limit *
interval_ms / 1000;
+ size_t backlog = _need_update_lru_blocks.size();
+ QueueConsumePlan plan = build_block_lru_update_plan(backlog);
Review Comment:
why the plan will work?
if we can consume as fast as we want, why not just consume them all?
##########
be/src/common/config.cpp:
##########
@@ -1246,6 +1246,16 @@
DEFINE_mInt64(file_cache_background_lru_dump_interval_ms, "60000");
DEFINE_mInt64(file_cache_background_lru_dump_update_cnt_threshold, "1000");
DEFINE_mInt64(file_cache_background_lru_dump_tail_record_num, "5000000");
DEFINE_mInt64(file_cache_background_lru_log_replay_interval_ms, "1000");
+DEFINE_mBool(enable_file_cache_adaptive_queue_consume, "true");
Review Comment:
too many knobs to understand.
pls try to make it simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
