github-actions[bot] commented on code in PR #63491:
URL: https://github.com/apache/doris/pull/63491#discussion_r3296637631
##########
be/src/exprs/table_function/vexplode_numbers.h:
##########
@@ -45,12 +45,12 @@ class VExplodeNumbersTableFunction : public TableFunction {
max_step = std::min(max_step, (int)(_cur_size - _cur_offset));
if (_is_const) {
if (_is_nullable) {
- static_cast<ColumnInt32*>(
-
static_cast<ColumnNullable*>(column.get())->get_nested_column_ptr().get())
+ assert_cast<ColumnInt32*>(
+
assert_cast<ColumnNullable*>(column.get())->get_nested_column_ptr().get())
->insert_range_from(*_elements_column, _cur_offset,
max_step);
- static_cast<ColumnUInt8*>(
-
static_cast<ColumnNullable*>(column.get())->get_null_map_column_ptr().get())
Review Comment:
This block is no longer clang-formatted: the statements inside `if
(_is_nullable)` are aligned with the `if` instead of being indented under it.
Please run the BE formatter for the whole PR.
##########
be/src/exec/operator/table_function_operator.cpp:
##########
@@ -343,8 +342,7 @@ Status
TableFunctionLocalState::_get_expanded_block_block_fast_path(
Review Comment:
This added line is over-indented relative to the surrounding block. The same
formatting drift appears in several touched BE files, so please run the
required Doris formatter (`build-support/clang-format.sh` with clang-format 16)
rather than fixing only this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
