englefly opened a new pull request, #63575:
URL: https://github.com/apache/doris/pull/63575
pick #62107
Issue Number: close #xxx
Problem Summary:
The EagerAggRewriter only blocked count(*)/count(literal) from being pushed
to the nullable side of outer joins (via instanceof Count check). But the same
logic applies to ALL aggregate functions whose input slots do not reference
columns from the target side, e.g. sum(2), min(1), max(3).
For unmatched rows in outer joins, these aggregates should produce their
literal-based result (e.g. sum(2) adds 2 per unmatched row). After incorrect
pushdown to the nullable side, the pre-aggregated slot becomes NULL for
unmatched rows, and sum(NULL)/min(NULL)/max(NULL) loses the contribution
entirely.
The fix generalizes the existing Count-only guard to all aggregate
functions: for any agg function with no input slots from the target side, block
pushdown to the nullable side of outer joins. agg(nullable_side_col) is still
safe to push because NULL values are naturally handled by aggregates.
case
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
