morningman commented on code in PR #14875:
URL: https://github.com/apache/doris/pull/14875#discussion_r1042238674
##########
be/src/vec/exec/format/file_reader/new_file_factory.h:
##########
@@ -0,0 +1,96 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Move this to `src/io/fs/`
##########
be/src/io/hdfs_reader_writer.h:
##########
@@ -39,6 +44,8 @@ class HdfsReaderWriter {
static Status create_writer(const std::map<std::string, std::string>&
properties,
const std::string& path,
std::unique_ptr<FileWriter>& writer);
-};
+ static Status create_new_reader(const THdfsParams& hdfs_params, const
std::string& path,
Review Comment:
Maybe we should move these methods to `file_factory` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
