liaoxin01 commented on code in PR #61324:
URL: https://github.com/apache/doris/pull/61324#discussion_r2960450568


##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/kafka/KafkaConfiguration.java:
##########
@@ -46,6 +46,20 @@ public enum KafkaConfiguration {
 
     
KAFKA_TEXT_TABLE_NAME_FIELD_DELIMITER("kafka_text_table_name_field_delimiter", 
",",
             value -> value.replace(" ", ""));
+
+    // Common Kafka property names used for security and authentication
+    // These are passed through property.* prefix and validated for correctness
+    public static final String SECURITY_PROTOCOL = "security.protocol";
+    public static final String SASL_MECHANISM = "sasl.mechanism";
+    public static final String SASL_JAAS_CONFIG = "sasl.jaas.config";
+
+    // AWS MSK IAM authentication properties
+    public static final String AWS_REGION = "aws.region";
+    public static final String AWS_ACCESS_KEY = "aws.access.key";

Review Comment:
   ```suggestion
       public static final String AWS_ACCESS_KEY = "aws.access_key";
       public static final String AWS_SECRET_KEY = "aws.secret_key";
       public static final String AWS_IAM_ROLE_ARN = "aws.role_arn";
       public static final String AWS_PROFILE_NAME = "aws.profile_name";
       public static final String AWS_CREDENTIALS_PROVIDER = 
"aws.credentials_provider";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to