ahmedsaid47 opened a new pull request, #61500:
URL: https://github.com/apache/doris/pull/61500
### What problem does this PR solve?
Issue Number: close #48203
Related PR: #48201
Problem Summary:
Add the Trino/Presto `typeof(expr)` scalar function in Nereids.
This implementation is FE-only and rewrites `typeof(...)` to a string
literal during analysis, so it does not require a BE runtime function. The
patch also adds Trino-compatible type display formatting for literals, casts,
arrays, maps, rows, decimals, and nested types.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
Manual test steps:
1. `cd fe && mvn package -pl fe-core -am -Dskip.doc=true -DskipTests
-Dcheckstyle.skip=true -T 1`
2. `mvn -pl fe-core -am -Dskip.doc=true -Dcheckstyle.skip=true
-Dtest=org.apache.doris.nereids.trees.expressions.functions.scalar.TypeOfTest
test`
3. Start a local FE runtime and verify `typeof` expressions are rewritten to
the expected varchar literals through FE analysis.
4. Probe the SQLs from
`regression-test/suites/external_table_p0/dialect_compatible/sql/presto/scalar/TestTypeOfFunction.sql`
against FE rewrite output to generate the expected `.out` content.
- Behavior changed:
- [ ] No.
- [x] Yes. Add `typeof(expr) -> varchar`.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]