xuchenhao commented on PR #59065: URL: https://github.com/apache/doris/pull/59065#issuecomment-4071998244
Thanks for the detailed review. Addressed for the 3 comments: 1. `discussion_r2942716467` (config mutability inconsistency) - Updated `file_cache_admission_control_json_dir` to `mutable = false` to align with startup-only watcher behavior. 2. `discussion_r2942716463` (`"hudi"` entry unreachable) - Removed `"hudi"` from `CACHEABLE_CATALOGS` and kept `"hms"`. - Updated comment to clarify: Hudi is supported via HMS (`Hudi(via HMS)`). 3. `discussion_r2942716455` (potential NPE in `fileCacheAdmissionCheck`) - Moved database extraction into the `ExternalTable` branch. - In non-external branch, keep safe logging with null checks and now include catalog/database/table in debug log. Please let me know if you prefer any wording/style adjustments in the log message format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
