yiguolei commented on code in PR #61130:
URL: https://github.com/apache/doris/pull/61130#discussion_r2938373237
##########
be/src/service/internal_service.cpp:
##########
@@ -1643,10 +1643,11 @@ void
PInternalService::rerun_fragment(google::protobuf::RpcController* controlle
PRerunFragmentResult* response,
google::protobuf::Closure* done) {
bool ret = _light_work_pool.try_offer([this, request, response, done]() {
- brpc::ClosureGuard closure_guard(done);
- auto st =
-
_exec_env->fragment_mgr()->rerun_fragment(UniqueId(request->query_id()).to_thrift(),
-
request->fragment_id(), request->stage());
+ std::shared_ptr<brpc::ClosureGuard> closure_guard =
Review Comment:
这个guard 就是为了自动调用的，如果不是自动调用，就不要构建guard了，直接把done 传递下去就好了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
