HappenLee commented on code in PR #60897:
URL: https://github.com/apache/doris/pull/60897#discussion_r2928639602
##########
be/src/storage/segment/condition_cache.cpp:
##########
@@ -49,4 +49,32 @@ void ConditionCache::insert(const CacheKey& key,
std::shared_ptr<std::vector<boo
result->capacity(), result->capacity(),
CachePriority::NORMAL));
}
+bool ConditionCache::lookup(const ExternalCacheKey& key, ConditionCacheHandle*
handle) {
Review Comment:
这里的能不能搞个通用的复用，把encode作为一个虚函数，统一传入Cache Key的引用，而不是写两遍呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
