HappenLee commented on code in PR #14513:
URL: https://github.com/apache/doris/pull/14513#discussion_r1033114797
##########
be/src/vec/aggregate_functions/aggregate_function_sum.cpp:
##########
@@ -31,7 +31,9 @@ namespace doris::vectorized {
template <typename T>
struct SumSimple {
/// @note It uses slow Decimal128 (cause we need such a variant).
sumWithOverflow is faster for Decimal32/64
- using ResultType = std::conditional_t<IsDecimalNumber<T>, Decimal128,
NearestFieldType<T>>;
+ using ResultType = std::conditional_t<
Review Comment:
template <typename T, typename U>
using dispose_decimal to replace to many ``` std::conditional_t<
IsDecimalV2<T>, Decimal128,
std::conditional_t<IsDecimalNumber<T>, Decimal128I```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
