zclllyybb commented on code in PR #61047:
URL: https://github.com/apache/doris/pull/61047#discussion_r2884126157
##########
be/src/vec/functions/array/function_array_utils.cpp:
##########
@@ -58,7 +59,9 @@ bool extract_column_array_info(const IColumn& src,
ColumnArrayExecutionData& dat
data.nested_type->get_primitive_type() != PrimitiveType::TYPE_VARIANT)
{
// set variant root column/type to from column/type
auto variant = ColumnVariant::create(true /*always nullable*/);
- variant->create_root(data.nested_type,
make_nullable(data.nested_col)->assume_mutable());
+ auto nullable_nested_type = make_nullable(data.nested_type);
+ auto nullable_col = make_nullable(data.nested_col);
+ variant->create_root(nullable_nested_type, nullable_col->clone());
Review Comment:
could `std::move` and `mutate` here. it will auto choose right way between
`clone()` and `assume_mutable()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
