morningman commented on code in PR #60557:
URL: https://github.com/apache/doris/pull/60557#discussion_r2802455882
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/doris/FeServiceClient.java:
##########
@@ -56,25 +81,26 @@ public class FeServiceClient {
private final String user;
private final String password;
private final int retryCount;
- private final int timeout;
+ private final int timeoutMs;
+ private volatile TNetworkAddress master;
Review Comment:
How about using `AtomicReference<TNetworkAddress>`？
##########
be/src/exec/tablet_info.cpp:
##########
@@ -447,6 +447,10 @@
VOlapTablePartitionParam::VOlapTablePartitionParam(std::shared_ptr<OlapTableSche
_overwrite_group_id = t_param.overwrite_group_id;
}
+ if (t_param.__isset.master_address) {
+ _master_address = new TNetworkAddress(t_param.master_address);
Review Comment:
better use smart pointer instead of raw pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
