dutyu commented on PR #14246: URL: https://github.com/apache/doris/pull/14246#issuecomment-1322917919
> if DorisSqlSeparator.g4 is not apart of Nereids, i suggest to move this file to `fe/fe-core/src/main/antlr4/org/apache/doris/parser` and move code about parser from `NereidsParser.java` to new file in `org.apache.doris.parser`. btw, maybe the better way to do this, is to save the origin stmt string in `StatementBase` when we parse sql using `sql_parser.cup`. Thanks for you suggestion, i will move it. Maybe community plans to use antlr4 to replace cup ( i am not sure ), it is a appropriate way to fix this issue by using antlr4, i've considered using the `text` field of `singleStatementContext`( in DorisParser.g4 ), but it does't contains any whitespace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
