luwei16 commented on code in PR #60310:
URL: https://github.com/apache/doris/pull/60310#discussion_r2758913568
##########
be/src/cloud/cloud_tablet_mgr.cpp:
##########
@@ -426,6 +426,12 @@ Status CloudTabletMgr::get_topn_tablets_to_compact(
auto now =
duration_cast<milliseconds>(system_clock::now().time_since_epoch()).count();
auto skip = [now, compaction_type](CloudTablet* t) {
auto* cloud_cluster_info =
static_cast<CloudClusterInfo*>(ExecEnv::GetInstance()->cluster_info());
+
+ // Compaction read-write separation: skip tablets that should be
compacted by other clusters
Review Comment:
// Placing this check here violates the invariant that the standby cluster
must not perform compaction in some scenarios.
##########
be/src/cloud/cloud_tablet_mgr.cpp:
##########
@@ -426,6 +426,12 @@ Status CloudTabletMgr::get_topn_tablets_to_compact(
auto now =
duration_cast<milliseconds>(system_clock::now().time_since_epoch()).count();
auto skip = [now, compaction_type](CloudTablet* t) {
auto* cloud_cluster_info =
static_cast<CloudClusterInfo*>(ExecEnv::GetInstance()->cluster_info());
+
+ // Compaction read-write separation: skip tablets that should be
compacted by other clusters
Review Comment:
Placing this check here violates the invariant that the standby cluster must
not perform compaction in some scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
