Copilot commented on code in PR #60386:
URL: https://github.com/apache/doris/pull/60386#discussion_r2747112683
##########
be/src/pipeline/exec/multi_cast_data_streamer.h:
##########
@@ -96,8 +96,7 @@ class MultiCastDataStreamer {
void _set_ready_for_read(int sender_idx);
void _block_reading(int sender_idx);
- Status _copy_block(RuntimeState* state, int32_t sender_idx,
vectorized::Block* block,
- MultiCastBlock& multi_cast_block);
+ Status _finish_pull(RuntimeState* state, MultiCastBlock& multi_cast_block);
Review Comment:
After removing the per-pull deep copy, the naming/comments around the pull
lifecycle are now misleading (e.g., `_un_finish_copy`, `_copying_count`, and
the struct comment that says blocks are copied during pull). This makes it
harder to reason about correctness and could lead to future regressions if
someone reintroduces mutations assuming copies are made. Consider renaming
these to reflect the new semantics (e.g., unfinished_pulls / active_pulls) and
updating the related comment to explicitly state the block is shared and relies
on COW/shallow-mutate behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
