Copilot commented on code in PR #60060:
URL: https://github.com/apache/doris/pull/60060#discussion_r2707575406
##########
docker/runtime/be/resource/be_disaggregated_entrypoint.sh:
##########
@@ -86,7 +86,7 @@ function add_cpu_limit_config()
# update config add `deploy_mode`.
update_conf_from_configmap()
{
- echo "" >> $DORIS_HOME/conf/be.conf
+ echo "########## doris-operator automatically adds ##########" >>
$DORIS_HOME/conf/be.conf
echo "deploy_mode = cloud" >> $DORIS_HOME/conf/be.conf
Review Comment:
The header and deploy_mode configuration are being written twice when
be.conf exists in the configmap. Lines 89-90 write to be.conf first, but then
when "be.conf" is found in the configmap loop (line 108), the file is copied
from configmap (line 109) which overwrites what was written at lines 89-90, and
then lines 110-111 write the header and deploy_mode again.
The writes at lines 89-90 should either be moved to only execute when
be.conf is NOT found in the configmap, or should be removed entirely if the
configmap logic handles all cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
