liaoxin01 commented on code in PR #14218:
URL: https://github.com/apache/doris/pull/14218#discussion_r1020745043


##########
be/src/olap/delta_writer.cpp:
##########
@@ -410,9 +417,14 @@ Status DeltaWriter::cancel() {
         _flush_token->cancel();
     }
     _is_cancelled = true;
+    _cancel_status = st;
     return Status::OK();
 }
 
+Status DeltaWriter::cancel() {
+    return cancel_with_status(Status::OK());

Review Comment:
   OLAPInternalError will generate stacktrace information. If the above method 
is used, the stacktrace information will be generated in advance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to