yiguolei commented on code in PR #59187:
URL: https://github.com/apache/doris/pull/59187#discussion_r2646809999


##########
be/src/pipeline/exec/scan_operator.cpp:
##########
@@ -295,150 +296,199 @@ Status 
ScanLocalState<Derived>::_normalize_conjuncts(RuntimeState* state) {
 
 template <typename Derived>
 Status ScanLocalState<Derived>::_normalize_predicate(vectorized::VExprContext* 
context,

Review Comment:
   这块逻辑,太复杂,我们得拆分一下,更容易加beut,否则后面很难维护了。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to