yiguolei commented on code in PR #13086: URL: https://github.com/apache/doris/pull/13086#discussion_r1013843794
########## be/src/exec/schema_scan_node.cpp: ########## @@ -127,7 +132,8 @@ Status SchemaScanNode::prepare(RuntimeState* state) { return Status::InternalError("schema scanner get nullptr pointer."); } - RETURN_IF_ERROR(_schema_scanner->init(&_scanner_param, _pool)); + RETURN_IF_ERROR( + _schema_scanner->init(&_scanner_param, _pool, schema_table->schema_table_type())); Review Comment: you could add a member schem table type in SchemaScanner so that init function could use the member instead of pass in a parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org