wangshuo128 commented on code in PR #12583: URL: https://github.com/apache/doris/pull/12583#discussion_r1013691586
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalGroupingSets.java: ########## @@ -0,0 +1,227 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.plans.logical; + +import org.apache.doris.nereids.memo.GroupExpression; +import org.apache.doris.nereids.properties.LogicalProperties; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.NamedExpression; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.VirtualSlotReference; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.trees.plans.PlanType; +import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; +import org.apache.doris.nereids.util.Utils; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; + +import java.util.ArrayList; +import java.util.BitSet; +import java.util.List; +import java.util.Objects; +import java.util.Optional; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * Grouping sets. + */ +public class LogicalGroupingSets<CHILD_TYPE extends Plan> extends LogicalRepeat<CHILD_TYPE> { + private final List<List<Expression>> groupingSets; + + public LogicalGroupingSets(List<List<Expression>> groupingSets, + List<NamedExpression> outputExpressions, + CHILD_TYPE child) { + this(groupingSets, genOriginalGroupByExpressions(groupingSets), outputExpressions, + Optional.empty(), Optional.empty(), child); + } + + public LogicalGroupingSets(List<List<Expression>> groupingSets, + List<Expression> groupByExpressions, + List<NamedExpression> outputExpressions, + List<BitSet> groupingIdList, + Set<VirtualSlotReference> virtualSlotRefs, + List<Expression> virtualGroupingExprs, + boolean changedOutput, + boolean isNormalized, + CHILD_TYPE child) { + this(groupingSets, groupByExpressions, outputExpressions, groupingIdList, + virtualSlotRefs, virtualGroupingExprs, changedOutput, + isNormalized, + Optional.empty(), Optional.empty(), child); + } + + public LogicalGroupingSets(List<List<Expression>> groupingSets, + List<Expression> groupByExpressions, + List<NamedExpression> outputExpressions, + Optional<GroupExpression> groupExpression, + Optional<LogicalProperties> logicalProperties, CHILD_TYPE child) { + super(PlanType.LOGICAL_GROUPING_SETS, groupByExpressions, outputExpressions, + groupExpression, logicalProperties, child); + this.groupingSets = groupingSets; + } + + public LogicalGroupingSets( + List<List<Expression>> groupingSets, + List<Expression> groupByExpressions, + List<NamedExpression> outputExpressions, + List<BitSet> groupingIdList, + Set<VirtualSlotReference> virtualSlotRefs, + List<Expression> virtualGroupingExprs, + boolean changedOutput, + boolean isNormalized, + Optional<GroupExpression> groupExpression, + Optional<LogicalProperties> logicalProperties, CHILD_TYPE child) { + super(PlanType.LOGICAL_GROUPING_SETS, groupByExpressions, outputExpressions, groupingIdList, + virtualSlotRefs, virtualGroupingExprs, changedOutput, + isNormalized, + groupExpression, logicalProperties, child); + this.groupingSets = groupingSets; + } + + @Override + public List<List<Expression>> getGroupingSets() { + return groupingSets; + } + + @Override + public String toString() { + return Utils.toSqlString("LogicalGroupingSets", + "outputExpressions", outputExpressions, + "grouping sets", groupingSets, + "original groupByExpressions", groupByExpressions, + "groupByExpressions", getGroupByExpressions() + ); + } + + @Override + public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { + return visitor.visitLogicalGroupingSets(this, context); + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + LogicalGroupingSets that = (LogicalGroupingSets) o; + return Objects.equals(groupingSets, that.groupingSets) + && super.equals(that); + } + + @Override + public int hashCode() { + return Objects.hash(groupingSets, groupByExpressions, outputExpressions, virtualSlotRefs, + groupingIdList, virtualGroupingExprs, changedOutput, isNormalized); + } + + @Override + public List<Expression> getExpressions() { + return new ImmutableList.Builder<Expression>() + .addAll(getGroupByExpressions()).addAll(outputExpressions).build(); + } + + @Override + public List<Slot> computeOutput() { + return new ImmutableList.Builder<Slot>() + .addAll(child().getOutput()) + .addAll(virtualGroupingExprs.stream() + .filter(VirtualSlotReference.class::isInstance) + .map(VirtualSlotReference.class::cast).collect(Collectors.toList())) + .build(); + } + + @Override + public LogicalGroupingSets<Plan> withChildren(List<Plan> children) { + Preconditions.checkArgument(children.size() == 1); + return new LogicalGroupingSets<>(groupingSets, groupByExpressions, outputExpressions, + groupingIdList, virtualSlotRefs, virtualGroupingExprs, + changedOutput, isNormalized, + children.get(0)); + } + + @Override + public LogicalGroupingSets<Plan> withGroupExpression(Optional<GroupExpression> groupExpression) { + return new LogicalGroupingSets<>(groupingSets, groupByExpressions, outputExpressions, + groupingIdList, virtualSlotRefs, virtualGroupingExprs, + changedOutput, isNormalized, + groupExpression, Optional.of(getLogicalProperties()), children.get(0)); + } + + @Override + public LogicalGroupingSets<Plan> withLogicalProperties(Optional<LogicalProperties> logicalProperties) { + return new LogicalGroupingSets<>(groupingSets, groupByExpressions, outputExpressions, + groupingIdList, virtualSlotRefs, virtualGroupingExprs, + changedOutput, isNormalized, + Optional.empty(), logicalProperties, children.get(0)); + } + + @Override + public LogicalGroupingSets<Plan> replace(List<List<Expression>> groupByExprList, + List<Expression> groupByExpressions, + List<NamedExpression> outputExpressionList, + List<BitSet> groupingIdList, + Set<VirtualSlotReference> virtualSlotRefs, + List<Expression> virtualGroupingExprs, + boolean changedOutput, + boolean isNormalized) { + return new LogicalGroupingSets<>(groupByExprList, groupByExpressions, outputExpressionList, + groupingIdList, virtualSlotRefs, virtualGroupingExprs, + changedOutput, isNormalized, child()); + } + + @Override + public LogicalGroupingSets<Plan> replaceWithChild(List<List<Expression>> groupByExprList, + List<Expression> groupByExpressions, + List<NamedExpression> outputExpressionList, + List<BitSet> groupingIdList, + Set<VirtualSlotReference> virtualSlotRefs, + List<Expression> virtualGroupingExprs, + boolean changedOutput, + boolean isNormalized, + Plan child) { + return new LogicalGroupingSets<>(groupByExprList, groupByExpressions, outputExpressionList, + groupingIdList, virtualSlotRefs, virtualGroupingExprs, + changedOutput, isNormalized, child); + } + + @Override + public List<BitSet> genGroupingIdList(List<Expression> groupingExprs, List<List<Expression>> groupingSets) { + List<BitSet> groupingIdList = new ArrayList<>(); + groupingSets.forEach(expressions -> { + BitSet bitSet = new BitSet(); + for (int i = 0; i < groupingExprs.size(); ++i) { + bitSet.set(i, expressions.contains(groupingExprs.get(i))); + } + if (!groupingIdList.contains(bitSet)) { + groupingIdList.add(bitSet); + } + }); + return groupingIdList; + } + + public static List<Expression> genOriginalGroupByExpressions(List<List<Expression>> groupingSets) { Review Comment: `genOriginalGroupByExpressions` -> `extractDistinctGroupByExpressions` ? ########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalGroupingSets.java: ########## @@ -0,0 +1,227 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.plans.logical; + +import org.apache.doris.nereids.memo.GroupExpression; +import org.apache.doris.nereids.properties.LogicalProperties; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.NamedExpression; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.VirtualSlotReference; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.trees.plans.PlanType; +import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; +import org.apache.doris.nereids.util.Utils; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; + +import java.util.ArrayList; +import java.util.BitSet; +import java.util.List; +import java.util.Objects; +import java.util.Optional; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * Grouping sets. + */ +public class LogicalGroupingSets<CHILD_TYPE extends Plan> extends LogicalRepeat<CHILD_TYPE> { + private final List<List<Expression>> groupingSets; + + public LogicalGroupingSets(List<List<Expression>> groupingSets, + List<NamedExpression> outputExpressions, + CHILD_TYPE child) { + this(groupingSets, genOriginalGroupByExpressions(groupingSets), outputExpressions, + Optional.empty(), Optional.empty(), child); + } + + public LogicalGroupingSets(List<List<Expression>> groupingSets, + List<Expression> groupByExpressions, + List<NamedExpression> outputExpressions, + List<BitSet> groupingIdList, + Set<VirtualSlotReference> virtualSlotRefs, + List<Expression> virtualGroupingExprs, + boolean changedOutput, + boolean isNormalized, + CHILD_TYPE child) { + this(groupingSets, groupByExpressions, outputExpressions, groupingIdList, + virtualSlotRefs, virtualGroupingExprs, changedOutput, + isNormalized, + Optional.empty(), Optional.empty(), child); + } + + public LogicalGroupingSets(List<List<Expression>> groupingSets, + List<Expression> groupByExpressions, + List<NamedExpression> outputExpressions, + Optional<GroupExpression> groupExpression, + Optional<LogicalProperties> logicalProperties, CHILD_TYPE child) { + super(PlanType.LOGICAL_GROUPING_SETS, groupByExpressions, outputExpressions, + groupExpression, logicalProperties, child); + this.groupingSets = groupingSets; + } + + public LogicalGroupingSets( + List<List<Expression>> groupingSets, + List<Expression> groupByExpressions, + List<NamedExpression> outputExpressions, + List<BitSet> groupingIdList, + Set<VirtualSlotReference> virtualSlotRefs, + List<Expression> virtualGroupingExprs, + boolean changedOutput, + boolean isNormalized, + Optional<GroupExpression> groupExpression, + Optional<LogicalProperties> logicalProperties, CHILD_TYPE child) { + super(PlanType.LOGICAL_GROUPING_SETS, groupByExpressions, outputExpressions, groupingIdList, + virtualSlotRefs, virtualGroupingExprs, changedOutput, + isNormalized, + groupExpression, logicalProperties, child); + this.groupingSets = groupingSets; + } + + @Override + public List<List<Expression>> getGroupingSets() { + return groupingSets; + } + + @Override + public String toString() { + return Utils.toSqlString("LogicalGroupingSets", + "outputExpressions", outputExpressions, + "grouping sets", groupingSets, + "original groupByExpressions", groupByExpressions, + "groupByExpressions", getGroupByExpressions() + ); + } + + @Override + public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { + return visitor.visitLogicalGroupingSets(this, context); + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + LogicalGroupingSets that = (LogicalGroupingSets) o; + return Objects.equals(groupingSets, that.groupingSets) + && super.equals(that); + } + + @Override + public int hashCode() { + return Objects.hash(groupingSets, groupByExpressions, outputExpressions, virtualSlotRefs, + groupingIdList, virtualGroupingExprs, changedOutput, isNormalized); + } + + @Override + public List<Expression> getExpressions() { + return new ImmutableList.Builder<Expression>() + .addAll(getGroupByExpressions()).addAll(outputExpressions).build(); + } + + @Override + public List<Slot> computeOutput() { + return new ImmutableList.Builder<Slot>() + .addAll(child().getOutput()) + .addAll(virtualGroupingExprs.stream() + .filter(VirtualSlotReference.class::isInstance) + .map(VirtualSlotReference.class::cast).collect(Collectors.toList())) + .build(); + } + + @Override + public LogicalGroupingSets<Plan> withChildren(List<Plan> children) { + Preconditions.checkArgument(children.size() == 1); + return new LogicalGroupingSets<>(groupingSets, groupByExpressions, outputExpressions, + groupingIdList, virtualSlotRefs, virtualGroupingExprs, + changedOutput, isNormalized, + children.get(0)); + } + + @Override + public LogicalGroupingSets<Plan> withGroupExpression(Optional<GroupExpression> groupExpression) { + return new LogicalGroupingSets<>(groupingSets, groupByExpressions, outputExpressions, + groupingIdList, virtualSlotRefs, virtualGroupingExprs, + changedOutput, isNormalized, + groupExpression, Optional.of(getLogicalProperties()), children.get(0)); + } + + @Override + public LogicalGroupingSets<Plan> withLogicalProperties(Optional<LogicalProperties> logicalProperties) { + return new LogicalGroupingSets<>(groupingSets, groupByExpressions, outputExpressions, + groupingIdList, virtualSlotRefs, virtualGroupingExprs, + changedOutput, isNormalized, + Optional.empty(), logicalProperties, children.get(0)); + } + + @Override + public LogicalGroupingSets<Plan> replace(List<List<Expression>> groupByExprList, + List<Expression> groupByExpressions, + List<NamedExpression> outputExpressionList, + List<BitSet> groupingIdList, + Set<VirtualSlotReference> virtualSlotRefs, + List<Expression> virtualGroupingExprs, + boolean changedOutput, + boolean isNormalized) { + return new LogicalGroupingSets<>(groupByExprList, groupByExpressions, outputExpressionList, + groupingIdList, virtualSlotRefs, virtualGroupingExprs, + changedOutput, isNormalized, child()); + } + + @Override + public LogicalGroupingSets<Plan> replaceWithChild(List<List<Expression>> groupByExprList, + List<Expression> groupByExpressions, + List<NamedExpression> outputExpressionList, + List<BitSet> groupingIdList, + Set<VirtualSlotReference> virtualSlotRefs, + List<Expression> virtualGroupingExprs, + boolean changedOutput, + boolean isNormalized, + Plan child) { + return new LogicalGroupingSets<>(groupByExprList, groupByExpressions, outputExpressionList, + groupingIdList, virtualSlotRefs, virtualGroupingExprs, + changedOutput, isNormalized, child); + } + + @Override + public List<BitSet> genGroupingIdList(List<Expression> groupingExprs, List<List<Expression>> groupingSets) { + List<BitSet> groupingIdList = new ArrayList<>(); + groupingSets.forEach(expressions -> { + BitSet bitSet = new BitSet(); + for (int i = 0; i < groupingExprs.size(); ++i) { + bitSet.set(i, expressions.contains(groupingExprs.get(i))); + } + if (!groupingIdList.contains(bitSet)) { + groupingIdList.add(bitSet); + } + }); + return groupingIdList; + } + + public static List<Expression> genOriginalGroupByExpressions(List<List<Expression>> groupingSets) { + List<Expression> groupingExpression = new ArrayList<>(); + groupingSets.forEach(groupingExpression::addAll); + return groupingExpression.stream().distinct().collect(ImmutableList.toImmutableList()); Review Comment: ```suggestion return groupingSets.stream() .flatMap(List::stream) .distinct() .collect(ImmutableList.toImmutableList()); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
