924060929 opened a new pull request, #13957:
URL: https://github.com/apache/doris/pull/13957
# Proposed changes
This pr fix some bug for run tpc-h
1. fix the avg(decimal) crash the backend. The fix code in
`Avg.getFinalType()`
2. fix the ReorderJoin dead loop. The fix code in
`ReorderJoin.findInnerJoin()`
New feature: support trace the rule, you can `set enable_nereids_trace=true`
to open trace log and see this log:
```
2022-11-03 21:07:38,391 INFO (mysql-nio-pool-0|208)
[Job.printTraceLog():128] ========== RewriteBottomUpJob ANALYZE_FILTER_SUBQUERY
==========
before:
LogicalProject ( projects=[S_ACCTBAL#17, S_NAME#13, N_NAME#4, P_PARTKEY#19,
P_MFGR#21, S_ADDRESS#14, S_PHONE#16, S_COMMENT#18] )
+--LogicalFilter ( predicates=((((((((P_PARTKEY#19 = PS_PARTKEY#7) AND
(S_SUPPKEY#12 = PS_SUPPKEY#8)) AND (P_SIZE#24 = 15)) AND (P_TYPE#23 like
'%BRASS')) AND (S_NATIONKEY#15 = N_NATIONKEY#3)) AND (N_REGIONKEY#5 =
R_REGIONKEY#0)) AND (R_NAME#1 = 'EUROPE')) AND (PS_SUPPLYCOST#10 =
(SCALARSUBQUERY) (QueryPlan: LogicalAggregate ( phase=LOCAL,
outputExpr=[min(PS_SUPPLYCOST#31) AS `min(PS_SUPPLYCOST)`#33], groupByExpr=[]
)), (CorrelatedSlots: [P_PARTKEY#19, S_SUPPKEY#12, S_NATIONKEY#15,
N_NATIONKEY#3, N_REGIONKEY#5, R_REGIONKEY#0, R_NAME#1]))) )
+--LogicalJoin ( type=CROSS_JOIN, hashJoinCondition=[],
otherJoinCondition=[] )
|--LogicalJoin ( type=CROSS_JOIN, hashJoinCondition=[],
otherJoinCondition=[] )
| |--LogicalJoin ( type=CROSS_JOIN, hashJoinCondition=[],
otherJoinCondition=[] )
| | |--LogicalJoin ( type=CROSS_JOIN, hashJoinCondition=[],
otherJoinCondition=[] )
| | | |--LogicalOlapScan (
qualified=default_cluster:regression_test_tpch_sf1_p1_tpch_sf1.part,
output=[P_PARTKEY#19, P_NAME#20, P_MFGR#21, P_BRAND#22, P_TYPE#23, P_SIZE#24,
P_CONTAINER#25, P_RETAILPRICE#26, P_COMMENT#27], candidateIndexIds=[],
selectedIndexId=11076, preAgg=ON )
| | | +--LogicalOlapScan (
qualified=default_cluster:regression_test_tpch_sf1_p1_tpch_sf1.supplier,
output=[S_SUPPKEY#12, S_NAME#13, S_ADDRESS#14, S_NATIONKEY#15, S_PHONE#16,
S_ACCTBAL#17, S_COMMENT#18], candidateIndexIds=[], selectedIndexId=11124,
preAgg=ON )
| | +--LogicalOlapScan (
qualified=default_cluster:regression_test_tpch_sf1_p1_tpch_sf1.partsupp,
output=[PS_PARTKEY#7, PS_SUPPKEY#8, PS_AVAILQTY#9, PS_SUPPLYCOST#10,
PS_COMMENT#11], candidateIndexIds=[], selectedIndexId=11092, preAgg=ON )
| +--LogicalOlapScan (
qualified=default_cluster:regression_test_tpch_sf1_p1_tpch_sf1.nation,
output=[N_NATIONKEY#3, N_NAME#4, N_REGIONKEY#5, N_COMMENT#6],
candidateIndexIds=[], selectedIndexId=11044, preAgg=ON )
+--LogicalOlapScan (
qualified=default_cluster:regression_test_tpch_sf1_p1_tpch_sf1.region,
output=[R_REGIONKEY#0, R_NAME#1, R_COMMENT#2], candidateIndexIds=[],
selectedIndexId=11108, preAgg=ON )
after:
LogicalProject ( projects=[S_ACCTBAL#17, S_NAME#13, N_NAME#4, P_PARTKEY#19,
P_MFGR#21, S_ADDRESS#14, S_PHONE#16, S_COMMENT#18] )
+--LogicalFilter ( predicates=((((((((P_PARTKEY#19 = PS_PARTKEY#7) AND
(S_SUPPKEY#12 = PS_SUPPKEY#8)) AND (P_SIZE#24 = 15)) AND (P_TYPE#23 like
'%BRASS')) AND (S_NATIONKEY#15 = N_NATIONKEY#3)) AND (N_REGIONKEY#5 =
R_REGIONKEY#0)) AND (R_NAME#1 = 'EUROPE')) AND (PS_SUPPLYCOST#10 =
min(PS_SUPPLYCOST)#33)) )
+--LogicalProject ( projects=[P_PARTKEY#19, P_NAME#20, P_MFGR#21,
P_BRAND#22, P_TYPE#23, P_SIZE#24, P_CONTAINER#25, P_RETAILPRICE#26,
P_COMMENT#27, S_SUPPKEY#12, S_NAME#13, S_ADDRESS#14, S_NATIONKEY#15,
S_PHONE#16, S_ACCTBAL#17, S_COMMENT#18, PS_PARTKEY#7, PS_SUPPKEY#8,
PS_AVAILQTY#9, PS_SUPPLYCOST#10, PS_COMMENT#11, N_NATIONKEY#3, N_NAME#4,
N_REGIONKEY#5, N_COMMENT#6, R_REGIONKEY#0, R_NAME#1, R_COMMENT#2,
min(PS_SUPPLYCOST)#33] )
+--LogicalApply ( correlationSlot=[P_PARTKEY#19, S_SUPPKEY#12,
S_NATIONKEY#15, N_NATIONKEY#3, N_REGIONKEY#5, R_REGIONKEY#0, R_NAME#1],
correlationFilter=Optional.empty )
|--LogicalJoin ( type=CROSS_JOIN, hashJoinCondition=[],
otherJoinCondition=[] )
| |--LogicalJoin ( type=CROSS_JOIN, hashJoinCondition=[],
otherJoinCondition=[] )
| | |--LogicalJoin ( type=CROSS_JOIN, hashJoinCondition=[],
otherJoinCondition=[] )
| | | |--LogicalJoin ( type=CROSS_JOIN, hashJoinCondition=[],
otherJoinCondition=[] )
| | | | |--LogicalOlapScan (
qualified=default_cluster:regression_test_tpch_sf1_p1_tpch_sf1.part,
output=[P_PARTKEY#19, P_NAME#20, P_MFGR#21, P_BRAND#22, P_TYPE#23, P_SIZE#24,
P_CONTAINER#25, P_RETAILPRICE#26, P_COMMENT#27], candidateIndexIds=[],
selectedIndexId=11076, preAgg=ON )
| | | | +--LogicalOlapScan (
qualified=default_cluster:regression_test_tpch_sf1_p1_tpch_sf1.supplier,
output=[S_SUPPKEY#12, S_NAME#13, S_ADDRESS#14, S_NATIONKEY#15, S_PHONE#16,
S_ACCTBAL#17, S_COMMENT#18], candidateIndexIds=[], selectedIndexId=11124,
preAgg=ON )
| | | +--LogicalOlapScan (
qualified=default_cluster:regression_test_tpch_sf1_p1_tpch_sf1.partsupp,
output=[PS_PARTKEY#7, PS_SUPPKEY#8, PS_AVAILQTY#9, PS_SUPPLYCOST#10,
PS_COMMENT#11], candidateIndexIds=[], selectedIndexId=11092, preAgg=ON )
| | +--LogicalOlapScan (
qualified=default_cluster:regression_test_tpch_sf1_p1_tpch_sf1.nation,
output=[N_NATIONKEY#3, N_NAME#4, N_REGIONKEY#5, N_COMMENT#6],
candidateIndexIds=[], selectedIndexId=11044, preAgg=ON )
| +--LogicalOlapScan (
qualified=default_cluster:regression_test_tpch_sf1_p1_tpch_sf1.region,
output=[R_REGIONKEY#0, R_NAME#1, R_COMMENT#2], candidateIndexIds=[],
selectedIndexId=11108, preAgg=ON )
+--LogicalAggregate ( phase=LOCAL,
outputExpr=[min(PS_SUPPLYCOST#31) AS `min(PS_SUPPLYCOST)`#33], groupByExpr=[] )
+--LogicalFilter ( predicates=(((((P_PARTKEY#19 = PS_PARTKEY#28)
AND (S_SUPPKEY#12 = PS_SUPPKEY#29)) AND (S_NATIONKEY#15 = N_NATIONKEY#3)) AND
(N_REGIONKEY#5 = R_REGIONKEY#0)) AND (CAST(R_NAME AS STRING) = CAST(EUROPE AS
STRING))) )
+--LogicalOlapScan (
qualified=default_cluster:regression_test_tpch_sf1_p1_tpch_sf1.partsupp,
output=[PS_PARTKEY#28, PS_SUPPKEY#29, PS_AVAILQTY#30, PS_SUPPLYCOST#31,
PS_COMMENT#32], candidateIndexIds=[], selectedIndexId=11092, preAgg=ON )
```
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
4. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
6. Does it need to update dependencies:
- [x] Yes
- [ ] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
