Kikyou1997 commented on code in PR #13883:
URL: https://github.com/apache/doris/pull/13883#discussion_r1012796595


##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatsDeriveResult.java:
##########
@@ -48,10 +48,7 @@ public StatsDeriveResult(double rowCount) {
 
     public StatsDeriveResult(StatsDeriveResult another) {
         this.rowCount = another.rowCount;
-        slotIdToColumnStats = new HashMap<>();
-        for (Entry<Id, ColumnStatistic> entry : 
another.slotIdToColumnStats.entrySet()) {
-            slotIdToColumnStats.put(entry.getKey(), entry.getValue().copy());
-        }
+        slotIdToColumnStats = new HashMap<>(another.slotIdToColumnStats);

Review Comment:
   All the member of `ColumnStatistic`  is already modified with `final` 
keyword so there is no need to copy again here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to