freemandealer commented on PR #13495:
URL: https://github.com/apache/doris/pull/13495#issuecomment-1298417747

   This pr will break somethings:
   1. disable_auto_compaction setting to true won't stop CumuThread working as 
expected
   2. page cache is used when doing compaction. see the print below:
   
   ```
   (gdb) bt
   #0  doris::StoragePageCache::insert (this=this@entry=0x55eb5ef87630 
<doris::StoragePageCache::create_global_cache(unsigned long, int, unsigned 
int)::instance>, key=..., data=...,
       handle=handle@entry=0x7ff503b30440, 
page_type=doris::segment_v2::INDEX_PAGE, in_memory=false) at 
/mnt/disk1/zhangzhengyu/project/doris-build/be/src/olap/page_cache.cpp:66
   #1  0x000055eb586e7457 in 
doris::segment_v2::PageIO::read_and_decompress_page (opts=..., 
handle=0x55eb6ddb3308, body=body@entry=0x7ff503b305c0, 
footer=footer@entry=0x7ff503b30640)
       at 
/mnt/disk1/zhangzhengyu/project/doris-build/be/src/olap/rowset/segment_v2/page_io.cpp:204
   #2  0x000055eb586f85f1 in operator() 
(__closure=__closure@entry=0x7ff503b308e8) at 
/mnt/disk1/zhangzhengyu/project/doris-build/be/src/olap/rowset/segment_v2/segment.cpp:208
   #3  0x000055eb586f8c3a in operator() (__closure=0x7ff503b308e0) at 
/mnt/disk1/zhangzhengyu/project/doris-build/be/src/util/once.h:57
   #4  std::__invoke_impl<void, 
doris::DorisCallOnce<doris::Status>::call<doris::segment_v2::Segment::load_index()::<lambda()>
 >(doris::segment_v2::Segment::load_index()::<lambda()>)::<lambda()> > (__f=...)
       at 
/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain/include/c++/11/bits/invoke.h:61
   #5  
std::__invoke<doris::DorisCallOnce<doris::Status>::call<doris::segment_v2::Segment::load_index()::<lambda()>
 >(doris::segment_v2::Segment::load_index()::<lambda()>)::<lambda()> > 
(__fn=...)
       at 
/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain/include/c++/11/bits/invoke.h:96
   #6  operator() (__closure=<optimized out>) at 
/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain/include/c++/11/mutex:776
   #7  operator() (__closure=<optimized out>) at 
/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain/include/c++/11/mutex:712
   #8  _FUN () at 
/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain/include/c++/11/mutex:712
   #9  0x00007ff5e3bcd4df in __pthread_once_slow (once_control=0x55eb6ddb32ac, 
init_routine=0x55eb5e675600 <__once_proxy>) at pthread_once.c:116
   #10 0x000055eb586f6aeb in __gthread_once (__func=<optimized out>, 
__once=0x55eb6ddb32ac) at 
/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain/include/x86_64-linux-gnu/c++/11/bits/gthr-default.h:700
   #11 
std::call_once<doris::DorisCallOnce<doris::Status>::call<doris::segment_v2::Segment::load_index()::<lambda()>
 >(doris::segment_v2::Segment::load_index()::<lambda()>)::<lambda()> > 
(__f=..., __once=...)
       at 
/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain/include/c++/11/mutex:783
   #12 
doris::DorisCallOnce<doris::Status>::call<doris::segment_v2::Segment::load_index()::<lambda()>
 > (fn=..., this=0x55eb6ddb32a8) at 
/mnt/disk1/zhangzhengyu/project/doris-build/be/src/util/once.h:57
   #13 doris::segment_v2::Segment::load_index (this=0x55eb6ddb3180) at 
/mnt/disk1/zhangzhengyu/project/doris-build/be/src/olap/rowset/segment_v2/segment.cpp:218
   #14 doris::segment_v2::Segment::new_iterator (this=0x55eb6ddb3180, 
schema=..., read_options=..., iter=iter@entry=0x7ff503b30c00)
       at 
/mnt/disk1/zhangzhengyu/project/doris-build/be/src/olap/rowset/segment_v2/segment.cpp:112
   #15 0x000055eb589ca230 in doris::BetaRowsetReader::init 
(this=0x55ec2a761a40, read_context=0x7ff503b313f8) at 
/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain/include/c++/11/bits/shared_ptr_base.h:1290
   #16 0x000055eb5b70526b in doris::vectorized::BlockReader::_init_collect_iter 
(this=this@entry=0x7ff503b313a0, read_params=..., 
valid_rs_readers=valid_rs_readers@entry=0x7ff503b30f90)
       at 
/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain/include/c++/11/bits/shared_ptr_base.h:1290
   #17 0x000055eb5b70924b in doris::vectorized::BlockReader::init 
(this=this@entry=0x7ff503b313a0, read_params=...) at 
/mnt/disk1/zhangzhengyu/project/doris-build/be/src/vec/olap/block_reader.cpp:136
   #18 0x000055eb583ca14a in doris::Merger::vmerge_rowsets (tablet=..., 
reader_type=<optimized out>, cur_tablet_schema=..., src_rowset_readers=..., 
dst_rowset_writer=dst_rowset_writer@entry=0x55ebcb7aa000,
       stats_output=0x7ff503b31a90) at 
/mnt/disk1/zhangzhengyu/project/doris-build/be/src/olap/merger.cpp:138
   #19 0x000055eb583c2ffc in doris::Compaction::do_compaction_impl 
(this=this@entry=0x55edd5833e00, permits=permits@entry=24) at 
/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain/include/c++/11/ext/atomicity.h:109
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to