[GitHub] [doris] ByteYue commented on a diff in pull request #13646: [enhancement](metric)Add metric for exec_state prepare function

[GitBox]

ByteYue commented on code in PR #13646:
URL: https://github.com/apache/doris/pull/13646#discussion_r1007039627


##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -61,6 +63,7 @@ namespace doris {
 DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(plan_fragment_count, MetricUnit::NOUNIT);
 DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(timeout_canceled_fragment_count, 
MetricUnit::NOUNIT);
 DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(fragment_thread_pool_queue_size, 
MetricUnit::NOUNIT);
+bvar::LatencyRecorder g_fragmentmgr_prepare_latency("doris_FragmentMgr", 
"prepare");

Review Comment:
   I did one test using this LatencyRecorder, it seemed that it could give us a 
whole view of latency and percentiles.
   
![image](https://user-images.githubusercontent.com/43750022/198329932-8fe5ce4a-2eb4-4f7c-9aa3-7bbc697444e4.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org