morningman commented on code in PR #13657:
URL: https://github.com/apache/doris/pull/13657#discussion_r1004558418


##########
be/src/util/jni-util.cpp:
##########
@@ -39,13 +39,17 @@ void FindOrCreateJavaVM() {
     if (rv == 0) {
         JNIEnv* env;
         JavaVMInitArgs vm_args;
-        JavaVMOption options[1];
+        JavaVMOption options[2];
         char* str = getenv("DORIS_JNI_CLASSPATH_PARAMETER");
         options[0].optionString = str;
+        // Set max heap size to 4G.
+        std::string heap_size("-Xmx4096M");

Review Comment:
   This should be a `config`



##########
fe/java-udf/pom.xml:
##########
@@ -70,6 +70,11 @@ under the License.
             <version>${junit.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>com.zaxxer</groupId>
+            <artifactId>HikariCP</artifactId>
+            <version>${hikaricp.version}</version>

Review Comment:
   Add this to `dist/LICENSE-dist.txt`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to