morningman commented on code in PR #13428:
URL: https://github.com/apache/doris/pull/13428#discussion_r999526366
##########
be/src/vec/exec/vbroker_scanner.cpp:
##########
@@ -91,9 +91,10 @@ Status VBrokerScanner::_fill_dest_columns(const Slice& line,
return Status::OK();
}
- if (!check_array_format(_split_values)) {
- return Status::OK();
- }
+ // This check is meaningless, should be removed
Review Comment:
This is done in `ConvertImplGenericFromString` in `function_cast.h`.
Just as you recommended, all malformat array string will return null.
##########
be/src/vec/functions/function_cast.h:
##########
@@ -332,9 +334,16 @@ struct ConvertImplGenericFromString {
continue;
}
ReadBuffer read_buffer((char*)(val.data), val.size);
- RETURN_IF_ERROR(data_type_to->from_string(read_buffer,
col_to));
+ Status st = data_type_to->from_string(read_buffer, col_to);
+ // if parsing failed, will return null
+ (*vec_null_map_to)[i] = !st.ok();
+ if (!st.ok()) {
+ col_to->insert_default();
+ }
}
- block.replace_by_position(result, std::move(col_to));
+ // block.replace_by_position(result, std::move(col_to));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
