freemandealer commented on code in PR #12866:
URL: https://github.com/apache/doris/pull/12866#discussion_r998998999
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -102,6 +115,409 @@ Status BetaRowsetWriter::add_block(const
vectorized::Block* block) {
return _add_block(block, &_segment_writer);
}
+vectorized::VMergeIterator* BetaRowsetWriter::_get_segcompaction_reader(
Review Comment:
Thanks for your suggestion. It seems to need large modification on the patch
and re-test. So I'd rather do it in further patches (maybe when add multi-pass
segcompaction). If this commit itself is good, I suggest to merge it as it is
-- a step by step methodology.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
