nextdreamblue commented on code in PR #13067: URL: https://github.com/apache/doris/pull/13067#discussion_r996450318
########## fe/fe-core/src/main/cup/sql_parser.cup: ########## @@ -2743,17 +2745,17 @@ drop_stmt ::= // Recover statement recover_stmt ::= - KW_RECOVER KW_DATABASE ident:dbName + KW_RECOVER KW_DATABASE ident:dbName opt_id:dbId opt_table_alias:alias Review Comment: 改了一版，发现这个地方如果不写表名的话，很多语法解析比如判断用户是否对该表名有权限很难做，只能从catalogrecyclebin中通过tableid获取到table后才能知道表名，然后才能回头再判断是否读该表有权限去恢复，这太绕了。不如让用户指定表名和id，成对的去恢复，对用户使用也没太大影响 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
