github-actions[bot] commented on PR #13143:
URL: https://github.com/apache/doris/pull/13143#issuecomment-1272460348
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/3213008669";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In docker/thirdparties/docker-compose/hive/gen_env.sh line 27:
cp ${ROOT}/hadoop-hive.env.tpl ${ROOT}/hadoop-hive.env
^-----^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
cp "${ROOT}"/hadoop-hive.env.tpl "${ROOT}"/hadoop-hive.env
In docker/thirdparties/docker-compose/hive/gen_env.sh line 30:
HOST_NAME=`hostname`
^--------^ SC2006 (style): Use $(...) notation instead of legacy
backticks `...`.
Did you mean:
HOST_NAME=$(hostname)
In docker/thirdparties/docker-compose/hive/gen_env.sh line 31:
echo "CORE_CONF_fs_defaultFS=hdfs://${HOST_NAME}:8020" >>
${ROOT}/hadoop-hive.env
^-----^ SC2086
(info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "CORE_CONF_fs_defaultFS=hdfs://${HOST_NAME}:8020" >>
"${ROOT}"/hadoop-hive.env
In docker/thirdparties/docker-compose/hive/gen_env.sh line 32:
echo "HOST_NAME=${HOST_NAME}" >> ${ROOT}/hadoop-hive.env
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
echo "HOST_NAME=${HOST_NAME}" >> "${ROOT}"/hadoop-hive.env
In docker/thirdparties/docker-compose/hive/scripts/healthy_check.sh line 19:
if [ ! -f "/mnt/SUCCESS" ]; then
^---------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests
in Bash/Ksh.
Did you mean:
if [[ ! -f "/mnt/SUCCESS" ]]; then
In docker/thirdparties/docker-compose/hive/scripts/hive-metastore.sh line 21:
if [ ! -d "/mnt/scritps/tpch1.db" ];then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
Did you mean:
if [[ ! -d "/mnt/scritps/tpch1.db" ]];then
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of
le...
https://www.shellcheck.net/wiki/SC2292 -- Prefer [[ ]] over [ ] for tests
i...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- docker/thirdparties/docker-compose/hive/gen_env.sh.orig
+++ docker/thirdparties/docker-compose/hive/gen_env.sh
@@ -27,6 +27,6 @@
cp ${ROOT}/hadoop-hive.env.tpl ${ROOT}/hadoop-hive.env
# Need to set hostname of container to same as host machine's.
# Otherwise, the doris process can not connect to namenode directly.
-HOST_NAME=`hostname`
-echo "CORE_CONF_fs_defaultFS=hdfs://${HOST_NAME}:8020" >>
${ROOT}/hadoop-hive.env
-echo "HOST_NAME=${HOST_NAME}" >> ${ROOT}/hadoop-hive.env
+HOST_NAME=$(hostname)
+echo "CORE_CONF_fs_defaultFS=hdfs://${HOST_NAME}:8020"
>>${ROOT}/hadoop-hive.env
+echo "HOST_NAME=${HOST_NAME}" >>${ROOT}/hadoop-hive.env
--- docker/thirdparties/docker-compose/hive/scripts/healthy_check.sh.orig
+++ docker/thirdparties/docker-compose/hive/scripts/healthy_check.sh
@@ -21,4 +21,3 @@
else
exit 0
fi
-
--- docker/thirdparties/docker-compose/hive/scripts/hive-metastore.sh.orig
+++ docker/thirdparties/docker-compose/hive/scripts/hive-metastore.sh
@@ -18,7 +18,7 @@
nohup /opt/hive/bin/hive --service metastore &
sleep 10
-if [ ! -d "/mnt/scritps/tpch1.db" ];then
+if [ ! -d "/mnt/scritps/tpch1.db" ]; then
echo "/mnt/scritps/tpch1.db does not exist"
exit 1
fi
@@ -30,6 +30,6 @@
touch /mnt/SUCCESS
# Avoid container exit
-while true;do
+while true; do
sleep 1
done
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
