sollhui commented on code in PR #56930:
URL: https://github.com/apache/doris/pull/56930#discussion_r2428098137
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskInfo.java:
##########
@@ -186,6 +188,21 @@ private void judgeEof(RLTaskTxnCommitAttachment
rlTaskTxnCommitAttachment) {
}
}
+ private void adaptiveMaxBatchInterval(RLTaskTxnCommitAttachment
rlTaskTxnCommitAttachment) {
+ RoutineLoadJob routineLoadJob = routineLoadManager.getJob(jobId);
+ if (rlTaskTxnCommitAttachment.getTotalRows() <
routineLoadJob.getMaxBatchRows()
+ && rlTaskTxnCommitAttachment.getReceivedBytes() <
routineLoadJob.getMaxBatchSizeBytes()
+ && rlTaskTxnCommitAttachment.getTaskExecutionTimeMs() >=
routineLoadJob.getMaxBatchIntervalS()) {
Review Comment:
Not exactly the same. For example, if reach the finish condition by
`max_bathc_size/rows`, we don't think it is EOF and also not increase
`max_batch_interval` adaptively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
