Kikyou1997 commented on code in PR #12987: URL: https://github.com/apache/doris/pull/12987#discussion_r984484857
########## fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStat.java: ########## @@ -54,7 +51,7 @@ * For example: * "@ndv = 10" means that the number distinct values is 10 in the whole table. */ -public class ColumnStats { +public class ColumnStat { Review Comment: 1. Is there any system support non-numeric type to do the stats calculation? Since we cannot find a proper way to map a value range of string type or complex type to a limited numeric range, it's meaningless to keep anything like LiteralExpr as min/max value. 2. I agreed that original stats shouldn't be modified, it should be copied when derive stats -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org