Kikyou1997 commented on code in PR #8864:
URL: https://github.com/apache/doris/pull/8864#discussion_r979992528
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsJobManager.java:
##########
@@ -80,16 +80,24 @@ public Map<Long, StatisticsJob> getIdToStatisticsJob() {
}
public void createStatisticsJob(AnalyzeStmt analyzeStmt) throws
UserException {
- // step1: init statistics job by analyzeStmt
- StatisticsJob statisticsJob =
StatisticsJob.fromAnalyzeStmt(analyzeStmt);
- writeLock();
- try {
- // step2: check restrict
- checkRestrict(analyzeStmt.getDbId(), statisticsJob.getTblIds());
- // step3: create it
- createStatisticsJob(statisticsJob);
- } finally {
- writeUnlock();
+ // The current statistics are only used for CBO test,
+ // and are not available to users. (work in progress)
+ // TODO(wzt): Further tests are needed
+ if (Config.enable_cbo_statistics) {
Review Comment:
Set it as a session variables rather than an options in configuration file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
