HappenLee commented on code in PR #12936:
URL: https://github.com/apache/doris/pull/12936#discussion_r979193618
##########
be/src/olap/rowset/segment_v2/page_io.cpp:
##########
@@ -34,7 +34,7 @@ namespace doris {
namespace segment_v2 {
using strings::Substitute;
-
+enum { PAGE_PADDING_SIZE = 16 };
Review Comment:
why not use static constexpr ？
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -760,6 +762,27 @@ Status FileColumnIterator::next_batch(size_t* n,
vectorized::MutableColumnPtr& d
_current_ordinal += nrows_to_read;
}
remaining -= nrows_in_page;
+ // If the column is string, there are many cost during resize chars
array, so that do such optimization:
Review Comment:
maybe we should impl the function in column string as a interface ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
