adonis0147 commented on code in PR #12852:
URL: https://github.com/apache/doris/pull/12852#discussion_r977277813
##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -360,40 +362,58 @@ class ColumnDictionary final : public COWHelper<IColumn,
ColumnDictionary<T>> {
if (code >= 0) {
return code;
}
- auto bound = std::upper_bound(_dict_data.begin(),
_dict_data.end(), value) -
- _dict_data.begin();
+ auto bound = std::upper_bound(_dict_data->begin(),
_dict_data->end(), value) -
+ _dict_data->begin();
return greater ? bound - greater + eq : bound - eq;
}
void find_codes(const phmap::flat_hash_set<StringValue>& values,
std::vector<vectorized::UInt8>& selected) const {
- size_t dict_word_num = _dict_data.size();
+ size_t dict_word_num = _dict_data->size();
selected.resize(dict_word_num);
selected.assign(dict_word_num, false);
- for (const auto& value : values) {
- if (auto it = _inverted_index.find(value); it !=
_inverted_index.end()) {
- selected[it->second] = true;
+ for (size_t i = 0; i < _dict_data->size(); i++) {
+ if (values.find((*_dict_data)[i]) != values.end()) {
+ selected[i] = true;
}
}
}
void clear() {
- _dict_data.clear();
- _inverted_index.clear();
- _code_convert_table.clear();
+ _dict_data->clear();
_hash_values.clear();
}
void clear_hash_values() { _hash_values.clear(); }
void sort() {
- size_t dict_size = _dict_data.size();
- _code_convert_table.reserve(dict_size);
- std::sort(_dict_data.begin(), _dict_data.end(), _comparator);
+ size_t dict_size = _dict_data->size();
+
+ _perm.resize(dict_size);
+ for (size_t i = 0; i < dict_size; ++i) {
+ _perm[i] = i;
+ }
+
+ struct Comparator {
+ public:
+ Comparator(DictContainer& dict_data) : _dict_data(dict_data) {}
+ bool operator()(const size_t a, const size_t b) const {
+ return _comparator(_dict_data[a], _dict_data[b]);
+ }
+
+ private:
+ StringValue::Comparator _comparator;
+ DictContainer& _dict_data;
+ };
+ Comparator comparator(*_dict_data);
+ std::sort(_perm.begin(), _perm.end(), comparator);
Review Comment:
```suggestion
std::sort(_perm.begin(), _perm.end(),
[&dict_data = *_dict_data, &comparator =
_comparator](const size_t a,
const size_t b) {
return comparator(dict_data[a], dict_data[b]);
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
