gavinchou commented on code in PR #55879:
URL: https://github.com/apache/doris/pull/55879#discussion_r2338347904
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -3428,22 +3430,15 @@ int
InstanceRecycler::recycle_rowset_meta_and_data(std::string_view rowset_meta_
LOG_WARNING("failed to get rowset ref count key").tag("err",
err);
return -1;
} else if (!txn->decode_atomic_int(value, &ref_count)) {
- LOG_WARNING("failed to decode rowset data ref count")
- .tag("key", hex(rowset_meta_key))
- .tag("rowset_id", rowset_id)
- .tag("tablet_id", tablet_id)
- .tag("value", hex(value));
+ LOG_WARNING("failed to decode rowset data ref
count").tag("value", hex(value));
Review Comment:
keep hex(key)
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -3428,22 +3430,15 @@ int
InstanceRecycler::recycle_rowset_meta_and_data(std::string_view rowset_meta_
LOG_WARNING("failed to get rowset ref count key").tag("err",
err);
return -1;
} else if (!txn->decode_atomic_int(value, &ref_count)) {
- LOG_WARNING("failed to decode rowset data ref count")
- .tag("key", hex(rowset_meta_key))
- .tag("rowset_id", rowset_id)
- .tag("tablet_id", tablet_id)
- .tag("value", hex(value));
+ LOG_WARNING("failed to decode rowset data ref
count").tag("value", hex(value));
return -1;
}
};
if (ref_count == 1) {
// It would not be added since it is recycling.
if (delete_rowset_data(rowset_meta) != 0) {
- LOG_WARNING("failed to delete rowset data")
- .tag("tablet_id", tablet_id)
- .tag("rowset_id", rowset_id)
- .tag("key", hex(rowset_meta_key));
+ LOG_WARNING("failed to delete rowset data");
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
