jackwener commented on code in PR #12818:
URL: https://github.com/apache/doris/pull/12818#discussion_r976455467
##########
fe/fe-core/src/test/java/org/apache/doris/catalog/ColumnGsonSerializationTest.java:
##########
@@ -117,6 +111,9 @@ public void testSerializeColumnList() throws IOException,
AnalysisException {
Assert.assertEquals(c1, columns.get(0));
Assert.assertEquals(c2, columns.get(1));
Assert.assertEquals(c3, columns.get(2));
+ // 3. Delete files
+ in.close();
Review Comment:
👍
##########
fe/fe-core/src/test/java/org/apache/doris/catalog/AdminStmtTest.java:
##########
@@ -20,21 +20,19 @@
import org.apache.doris.analysis.AdminSetReplicaStatusStmt;
import org.apache.doris.catalog.MaterializedIndex.IndexExtState;
import org.apache.doris.catalog.Replica.ReplicaStatus;
-import org.apache.doris.common.AnalysisException;
import org.apache.doris.common.Pair;
import org.apache.doris.persist.SetReplicaStatusOperationLog;
import org.apache.doris.utframe.TestWithFeService;
import com.google.common.collect.Lists;
-import org.junit.Assert;
+import org.junit.jupiter.api.Assertions;
Review Comment:
Good👍, Nereids already use junit 5 allover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
