[GitHub] [doris] morrySnow commented on a diff in pull request #12766: [feature-wip](statistics) add statistics module related syntax

[GitBox]

morrySnow commented on code in PR #12766:
URL: https://github.com/apache/doris/pull/12766#discussion_r976009405


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowTableStatsStmt.java:
##########
@@ -68,6 +71,13 @@ public String getDbName() {
         return tableName.getDb();
     }
 
+    public List<String> getPartitionNames() {
+        if (partitionNames == null) {
+            return Lists.newArrayList();

Review Comment:
   ditto



##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowColumnStatsStmt.java:
##########
@@ -43,22 +43,35 @@ public class ShowColumnStatsStmt extends ShowStmt {
                     .add(ColumnStats.MAX_VALUE.getValue())
                     .build();
 
-    private TableName tableName;
+    private final TableName tableName;
+    private final PartitionNames partitionNames;
 
-    public ShowColumnStatsStmt(TableName tableName) {
+    public ShowColumnStatsStmt(TableName tableName, PartitionNames 
partitionNames) {
         this.tableName = tableName;
+        this.partitionNames = partitionNames;
     }
 
     public TableName getTableName() {
         return tableName;
     }
 
+    public List<String> getPartitionNames() {
+        if (partitionNames == null) {
+            return Lists.newArrayList();

Review Comment:
   ```suggestion
               return Collections.emptyList();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org