[GitHub] [doris] zhangstar333 commented on a diff in pull request #12730: [Refactor](parquet) refactor parquet write to uniform and consistent logic

[GitBox]

zhangstar333 commented on code in PR #12730:
URL: https://github.com/apache/doris/pull/12730#discussion_r975971243


##########
be/src/runtime/file_result_writer.h:
##########
@@ -42,8 +42,15 @@ struct ResultFileOptions {
     std::vector<TNetworkAddress> broker_addresses;
     std::map<std::string, std::string> broker_properties;
     std::string success_file_name = "";
-    std::vector<std::vector<std::string>> schema;
-    std::map<std::string, std::string> file_properties;
+    std::vector<std::vector<std::string>> schema;       //not use in outfile 
with parquet format
+    std::map<std::string, std::string> file_properties; //not use in outfile 
with parquet format
+
+    std::vector<TParquetRepetitionType::type> schemas_repetition_type;
+    std::vector<TParquetDataType::type> schemas_data_type;
+    std::vector<std::string> schemas_column_name;

Review Comment:
   OK, I will update this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org